Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ember 3.24 release #867

Merged
merged 11 commits into from
Jan 7, 2021
Merged

Ember 3.24 release #867

merged 11 commits into from
Jan 7, 2021

Conversation

locks
Copy link
Contributor

@locks locks commented Dec 23, 2020 •
edited
Loading

No description provided.

@locks locks changed the title add post template Ember 3.24 release Dec 23, 2020
@locks GitHub Codespaces
Copy link
Contributor Author

locks commented Dec 23, 2020

emberjs/ember.js#19223 (comment)

Engine users will need to update to a newer ember-engines.

@ijlee2 ijlee2 force-pushed the release-3-24 branch 2 times, most recently from 6a91d50 to a458c9c Compare December 28, 2020 18:29
locks
locks commented Jan 5, 2021
View reviewed changes
content/ember-3-24-released.md

## Ember Data

Ember Data is the official data persistence library for Ember.js applications.
Copy link
Contributor Author

@locks locks Jan 5, 2021 •
edited by ijlee2
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/emberjs/data/blob/v3.24.0/CHANGELOG.md

Release 3.24.0 (January 4, 2021)

  • #7350 [Chore]: convert adapters to class syntax
  • #7359 [CI]: bump failure asset size to 75 bytes
  • #7369 [CHORE] Bump @ember/ordered-set
  • #7370 Don't expose the value of a model's attribute in assertions (#7370)
  • #7363 [BUGFIX identifiers] Address issue with polymorphic findRecord

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@igorT @snewcomer Hello. I think you helped with the Ember Data 3.24 release?

I noticed that 7363. Address issue with polymorphic findRecord had been included in the 3.23 release. I was wondering if the changelog might have added a duplicate entry for 3.24. Can you let us know if 7363 should be included in the 3.24 release blog post? Thanks.

@ijlee2 ijlee2 marked this pull request as ready for review January 6, 2021 21:01
@ijlee2 ijlee2 requested review from a team January 6, 2021 21:01
kennethlarsen
kennethlarsen approved these changes Jan 7, 2021
View reviewed changes
Copy link
Member

@kennethlarsen kennethlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ✨

@locks locks merged commit 383e0ea into master Jan 7, 2021
@locks locks deleted the release-3-24 branch January 7, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijlee2 ijlee2 ijlee2 left review comments

@jaredgalanis jaredgalanis jaredgalanis approved these changes

@RobbieTheWagner RobbieTheWagner RobbieTheWagner approved these changes

@kennethlarsen kennethlarsen kennethlarsen approved these changes

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@locks @rwjblue @kennethlarsen @RobbieTheWagner @jaredgalanis @ijlee2